search

k8snetworkplumbingwg / multi-networkpolicy

Apache License 2.0
19 stars 11 forks source link

SharedInformerFactory missing a Shutdown method #22

Open trozet opened 5 months ago

trozet commented 5 months ago

The Shutdown method is useful for waiting for the informer to be stopped when running unit tests: https://github.com/kubernetes/code-generator/commit/e4b7976d1aa480d750be54b0177e5e29790de3bb

It is missing: https://github.com/k8snetworkplumbingwg/multi-networkpolicy/blob/master/pkg/client/informers/externalversions/internalinterfaces/factory_interfaces.go#L34

I tried updating code-gen and regenerating, but it doesnt seem to work. Not sure why...

jcaamano commented 4 months ago

WE have a similar situation with the NAD factory

tssurya commented 4 months ago

yeah hit this with the NAD factory today (I wonder if there is another issue for NAD or if we should open one...)