k8snetworkplumbingwg / multus-cni

A CNI meta-plugin for multi-homed pods in Kubernetes
Apache License 2.0
2.29k stars 575 forks source link

Add watch permission to thick e2e template #1208

Closed LionelJouin closed 6 months ago

LionelJouin commented 6 months ago

As described in #1171, the watch function is required in the clusterrole for the thick Multus version, otherwise "Failed to watch *v1.Pod" would be returned.

This permission is still missing in e2e/templates/multus-daemonset-thick.yml.j2

coveralls commented 6 months ago

Coverage Status

coverage: 63.296%. remained the same when pulling 684147cdd8a084a7f2e143586bae097536f5f1b1 on LionelJouin:fix-1186 into a70da3556a41a04386e1f8049c2ea18f5feebc61 on k8snetworkplumbingwg:master.

s1061123 commented 6 months ago

LGTM, merged.