k8snetworkplumbingwg / multus-cni

A CNI meta-plugin for multi-homed pods in Kubernetes
Apache License 2.0
2.29k stars 575 forks source link

Skips checking for readiness on CNI DEL #1235

Closed dougbtv closed 5 months ago

dougbtv commented 5 months ago

Because deletes should favor a successful path, the readiness check should be skipped for pod removals.

This can cause an issue where there's pods pending deletes and that might impact scheduling of a pod that may be necessary in order to set the readiness indicator.

coveralls commented 5 months ago

Coverage Status

coverage: 62.916% (-0.1%) from 63.051% when pulling a1915e1a8e35c4829135491dbf520adb7a7925e4 on dougbtv:remove-readiness-check-on-del into 53a68c35ffc9dbdf61960b85309714ebc381613d on k8snetworkplumbingwg:master.