On the CNI request failure, multus-cni prints out cmdArgs. In all cases, except for debug printing, this is done with %s and a special printing function. However, the handleCNIRequest is an exception for some reason. That leads to unintelligible error messages in case of CNI request failures (severely abridged):
printCmdArgs() should be used for this case as well to avoid huge hardly readable logs.
At the same time, the content of cniCmdArgs is always appended to the error twice as seen in the example above. The first time by the HandleCNIRequest and another time by the handleCNIRequest. Same for the HandleDelegateRequest path.
Just removing the prefixing from the lower level handlers while keeping higher level ones. The ERRORED part migrated to the higher level handler functions to preserve the overall look of the error.
coverage: 62.778% (+0.03%) from 62.749%
when pulling ddc78f1244c38670d534ebc117a5fb7646ff7ef2 on igsilya:failure-logs
into 5f0b4cdc6b1554013a71303fce7c20c8f7b7b490 on k8snetworkplumbingwg:master.
On the CNI request failure, multus-cni prints out
cmdArgs
. In all cases, except for debug printing, this is done with%s
and a special printing function. However, thehandleCNIRequest
is an exception for some reason. That leads to unintelligible error messages in case of CNI request failures (severely abridged):printCmdArgs()
should be used for this case as well to avoid huge hardly readable logs.At the same time, the content of
cniCmdArgs
is always appended to the error twice as seen in the example above. The first time by theHandleCNIRequest
and another time by thehandleCNIRequest
. Same for theHandleDelegateRequest
path.Just removing the prefixing from the lower level handlers while keeping higher level ones. The
ERRORED
part migrated to the higher level handler functions to preserve the overall look of the error.