Update e2e tests (replace j2cli with gomplate)

k8snetworkplumbingwg / multus-cni

A CNI meta-plugin for multi-homed pods in Kubernetes

Apache License 2.0

2.41k stars 584 forks source link

Update e2e tests (replace j2cli with gomplate) #1265

Closed s1061123 closed 7 months ago

s1061123 commented 7 months ago

Fix #1264

coveralls commented 7 months ago

coverage: 62.778%. remained the same when pulling 82302ccab0fbba8bfceab64da34594777da458fd on s1061123:e2e-update into 9c2771b84273da7a77772219d8dd54c2869d96bf on k8snetworkplumbingwg:master.

killianmuldoon commented 7 months ago

Am I right in seeing that this tool is only used on the e2e/templates folder and that it only sets the CNI_VERSION in ~4 places?

If so maybe envsubst is a good replacement - it's installed on most systems and it's exactly for this use case.

s1061123 commented 7 months ago

I got it. May need to file another one.