search

k8snetworkplumbingwg / multus-cni

A CNI meta-plugin for multi-homed pods in Kubernetes
Apache License 2.0
2.27k stars 577 forks source link

Basic helm chart as source of the provided yamls #1269

Closed micw closed 1 month ago

micw commented 2 months ago

Hello,

I have seen that there are multiple attempts to create (and maintain) a helm chart for multus. Unfortunately, all of them seems to be outdated (maybe except the bitname one but this seems to be very customized and dot following the current example yamls in this project).

What do you think about a basic helm chart that is part of this project and contains just the stuff that is currently in the examples in "deployments"? So instead of maintaining the yaml examples, this project could maitain the helm chart. The examples then can simply be generated out of the helm chart. This way, there's no additional maintenance overhead but there would be an "official" helm chart.

If you're open to this, I'd create a PR for a initial chart, containing what's already in the example yamls.

Kind regards, Michael.

micw commented 2 months ago

To show what I mean, I have started with an initial helm chart and a script that generates the content of multus-daemonset.yml: https://github.com/micw/multus-cni/tree/feature/helm-chart/deployments

Please let me know what you think.

dougbtv commented 1 month ago

@micw we'd love your contributions against the helm charts -- it's one of those places where there's always more contributions necessary, you can find the charts @ https://github.com/k8snetworkplumbingwg/helm-charts

And if you would like to interact with us about the changes, feel free to join our maintainer calls, connection info @ https://github.com/k8snetworkplumbingwg/community

ianb-mp commented 1 week ago

Just to contribute my 2c worth...

you can find the charts @ https://github.com/k8snetworkplumbingwg/helm-charts

As discussed here that repo looks abandoned.

Having a helm chart is only 1/2 of the picture - it's also necessary to make it available via a chart repository. sriov-network-operator solves this by pushing the chart to GHCR as an OCI registry asset which seems nicer than using gh-pages to host the chart.