thin plugin: Handle `--multus-master-cni-file-name` flag

k8snetworkplumbingwg / multus-cni

A CNI meta-plugin for multi-homed pods in Kubernetes

Apache License 2.0

2.27k stars 577 forks source link

thin plugin: Handle `--multus-master-cni-file-name` flag #1270

Closed ordovicia closed 2 months ago

ordovicia commented 2 months ago

Multus v3.9.3 has --multus-master-cni-file-name flag to specify the name of a primary CNI config file. https://github.com/k8snetworkplumbingwg/multus-cni/blob/v3.9.3/images/entrypoint.sh#L22

In Multus v4.0.2, the thin plugin has the flag defined, but it is not read and so does not have effect.

This pull request fixes the problem by making the thin plugin correctly handles --multus-master-cni-file-name flag.

Fixes #1226

coveralls commented 2 months ago

coverage: 63.051% (-0.1%) from 63.17% when pulling 633985d82fd700a7f6ebdbb6dd1f529307ed4260 on ordovicia:thin-master-cni-file-flag into c6a371b6bc98293309432fab3934a6ddaa00b752 on k8snetworkplumbingwg:master.

s1061123 commented 2 months ago

@ordovicia, Looks good to me, thank you for the PR!