search

k8snetworkplumbingwg / multus-cni

A CNI meta-plugin for multi-homed pods in Kubernetes
Apache License 2.0
2.27k stars 577 forks source link

Not exposed APIReadyCheckFunc to outside of package #1286

Closed s1061123 closed 1 month ago

s1061123 commented 1 month ago

https://github.com/k8snetworkplumbingwg/multus-cni/actions/runs/9225475657 recommends to change the code, so this PR fix the code. In addition, APIReadyCheckFunc can be decaptalize (i.e not expose this type to outisde of package), so change it decaptalized.

comment on exported type APIReadyCheckFunc should be of the form "APIReadyCheckFunc ..." (with optional leading article) test (1.21.x, ubuntu-latest): pkg/server/api/shim.go#L44
type name will be used as api.APIReadyCheckFunc by other packages, and that stutters; consider calling this ReadyCheckFunc
coveralls commented 1 month ago

Coverage Status

coverage: 63.116%. remained the same when pulling d23856b784e5d8e6c08cc49987bf67791c7c61c8 on s1061123:fix-type-scope-comment into 9f5c0239a804a90bf8913c9a386ca50eff9ce0cc on k8snetworkplumbingwg:master.