Cleanup multus conf on exit

k8snetworkplumbingwg / multus-cni

A CNI meta-plugin for multi-homed pods in Kubernetes

Apache License 2.0

2.27k stars 577 forks source link

Cleanup multus conf on exit #1299

Open adrianchiris opened 3 weeks ago

adrianchiris commented 3 weeks ago

if cleanup-config-on-exit is set delete generated multus config file on exit.
add an option to skip watch for master cni config and kubeconfig as cleanup-config-on-exit with multus-conf-file=auto also triggered the watch for cases when deletion of multus config is desired but watch isnt
setup signal handling to allow config file cleanup on exit

adrianchiris commented 3 weeks ago

This is a proposed alternative to : #1298

as we used to clean up multus conf file in preStop hook, however since the container no longer has shell we cannot run simple sh commands for cleanup.

coveralls commented 3 weeks ago

coverage: 62.736% (-0.4%) from 63.116% when pulling 4198a768b0ba632b634aca3e61b5dde1fa8602a0 on adrianchiris:cleanup-multus-conf into aff99fccc5fe3b21aec84bb56a6d1bbaf8ffc45b on k8snetworkplumbingwg:master.

coveralls commented 2 weeks ago

coverage: 62.667% (-0.4%) from 63.116% when pulling 273c175f97b740b78a4d523f0106695abb12555a on adrianchiris:cleanup-multus-conf into 41013e7580396629a02213019baad1d0c84a6a2c on k8snetworkplumbingwg:master.

coveralls commented 2 weeks ago

coverage: 62.667% (-0.4%) from 63.116% when pulling ecc67c7de735f64145cae6720ad8c04c5602da2c on adrianchiris:cleanup-multus-conf into 41013e7580396629a02213019baad1d0c84a6a2c on k8snetworkplumbingwg:master.