search

k8snetworkplumbingwg / multus-service-archived

(TBD)
Apache License 2.0
27 stars 9 forks source link

containerd support #9

Open obiTrinobiIntel opened 2 years ago

obiTrinobiIntel commented 2 years ago

Multus service currently can be configured with docker and crio, is it possible to support containerd runtime ?

davecremins commented 2 years ago

Any updates on this request?

s1061123 commented 2 years ago

Thank you for the report, @obiTrinobiIntel and @davecremins .

As far as I know of, multus-service should work with containerd because containerd supports cri. You may need to change deployment yaml to adopt the cri socket path, but it does not require any go code change.

Could you please try that and let me know the feedback for that? Thanks!

davecremins commented 2 years ago

Thanks Tomo, we will modify the yaml spec and deploy. I will post updates here once we run the test.

On Tue, Aug 2, 2022 at 7:49 PM Tomofumi Hayashi @.***> wrote:

Thank you for the report, @obiTrinobiIntel https://github.com/obiTrinobiIntel and @davecremins https://github.com/davecremins .

As far as I know of, multus-service should work with containerd because containerd supports cri. You may need to change deployment yaml to adopt the cri socket path, but it does not require any go code change.

Could you please try that and let me know the feedback for that? Thanks!

— Reply to this email directly, view it on GitHub https://github.com/k8snetworkplumbingwg/multus-service/issues/9#issuecomment-1203091053, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJTM3X3TOIZR3SOJK3UBYTVXFUTFANCNFSM54SYSXIQ . You are receiving this because you were mentioned.Message ID: @.***>

s1061123 commented 1 year ago

@davecremins It is 3month+ since you replied. Did you check that? If you don't mind it, I will close this issue.

s1061123 commented 1 year ago

@davecremins followup. Does it works? If you don't test it yet, I will test it and close this if it works.