k8snetworkplumbingwg / net-attach-def-admission-controller

An admission controller to check resources as defined by the NPWG spec
Apache License 2.0
4 stars 15 forks source link

Fixes Network Attachment CRD refs #25

Closed trozet closed 5 years ago

trozet commented 5 years ago

The Network Attachment CRD is duplicated in multus-cni and K8sNetworkPlumbingWG org. This patch removes references to the ones defined in multus-cni in favor of the standardized definitions, which also include API libs as well.

Signed-off-by: Tim Rozet trozet@redhat.com

dougbtv commented 5 years ago

@trozet thanks for the PR! This should be a nice improvement here, thanks for picking this up and having it do the right thing with the inclusion of the k8snetworkplumbingwg/network-attachment-definition-client.

Looks good in general to me, but Travis seems to be complaining if you don't mind taking a look, thanks!

trozet commented 5 years ago

missed a couple places, will fix

s1061123 commented 5 years ago

Looks good to me, thanks!