Compilation with Golang 1.10

k8snetworkplumbingwg / net-attach-def-admission-controller

An admission controller to check resources as defined by the NPWG spec

Apache License 2.0

4 stars 15 forks source link

Compilation with Golang 1.10 #3

Closed dougbtv closed 5 years ago

dougbtv commented 5 years ago

I have scenarios where I'll need to compile with golang 1.10. I'm currently trying to fish out the issue and make it compatible, this error does not occur with golang 1.11, but, appears to with 1.10.

$ go install ./...
# github.com/K8sNetworkPlumbingWG/net-attach-def-admission-controller/vendor/k8s.io/apimachinery/pkg/runtime/serializer/json
vendor/k8s.io/apimachinery/pkg/runtime/serializer/json/json.go:104:16: unknown field 'caseSensitive' in struct literal of type jsoniter.Config

dougbtv commented 5 years ago

Located relevant issue: https://github.com/kubernetes/apimachinery/issues/46

dougbtv commented 5 years ago

Needed to pin the github.com/json-iterator/go package with:

- package: github.com/json-iterator/go
  version: f2b4162afba35581b6d4a50d3b8f34e33c144682

dougbtv commented 5 years ago

Fixed in #4