k8snetworkplumbingwg / net-attach-def-admission-controller

An admission controller to check resources as defined by the NPWG spec
Apache License 2.0
4 stars 15 forks source link

Multus metrics #30

Closed aneeshkp closed 5 years ago

aneeshkp commented 5 years ago

Enables metrics to addmission contoller. Metrics are available at :9091/metrtics

Desc: Metric to count network attachment definitions.". Name: network_attachment_definitions_count

Desc:Metric to get total pods using multus Name: multus_pod_count

Desc:multus_enabled_instance_up (Either 0 or 1) Name: Metric to identify clusters with multus enabled instances.

aneeshkp commented 5 years ago

@dougbtv @s1061123 , Added metrics for sriov and multus. Removed CR metrics, it was not accurate unless we introduced controller watching for net-attch-def resource. Following metrics are available for telemetry (check metrics doc linked in readme ) The netowrks label will have unique network type names configured for a pod. any= will give count for all types configured.
list = will have unique n/w type name sriov= is special , pick those pod that have sriov type configured This will give you count for each network type

network_attachment_definition_instance_total{networks="any"}    8
network_attachment_definition_instance_total{networks="bridge,macvlan"} 2
network_attachment_definition_instance_total{networks="macvlan"}    3 
network_attachment_definition_instance_total{networks="sriov"}  3 

and This will indicate whether the cluster has enabled or not for network types (here you will see one metric per type)

network_attachment_definition_enabled_instance_up{networks="any"}  1
network_attachment_definition_enabled_instance_up{networks="bridge"} 1
network_attachment_definition_enabled_instance_up{networks="macvlan"}  1
network_attachment_definition_enabled_instance_up{networks="sriov"}  1

I will be requesting network_attachment_definition_enabled_instance_up and network_attachment_definition_instance_total for telemetry. Hope thats good for this now.