search

k8snetworkplumbingwg / net-attach-def-admission-controller

An admission controller to check resources as defined by the NPWG spec
Apache License 2.0
4 stars 15 forks source link

Fixed metrics count issue #35

Closed aneeshkp closed 4 years ago

aneeshkp commented 4 years ago
  1. Previously, metrics was updated for every pod create event without considering pod status. Now the metric is considered only if the pod phase=running .
  2. Previously, eventType struct was stored as key for processing the item, this caused multiple entry for the same pod with different event, Now only storing the pod namespace/name as key for processing.
  3. Added update event handler to capture updates on the pod.
  4. Added store to keep track of pods that are considered for metrics along with network types.
aneeshkp commented 4 years ago

@s1061123 Added commit comments in details

aneeshkp commented 4 years ago

Cc @dougbtv @s1061123

dougbtv commented 4 years ago

in reference to this bz: https://bugzilla.redhat.com/show_bug.cgi?id=1770387