k8snetworkplumbingwg / net-attach-def-admission-controller

An admission controller to check resources as defined by the NPWG spec
Apache License 2.0
4 stars 15 forks source link

Add metrics for infiniband sriov #40

Closed zshi-redhat closed 4 years ago

zshi-redhat commented 4 years ago

/cc @aneeshkp @dougbtv @s1061123

aneeshkp commented 4 years ago

@zshi-redhat , looks good, just minor update to to the docs/metrics.md. change this They are grouped by network types for any and sriov only. to include ib-sriov and example.

zshi-redhat commented 4 years ago

@zshi-redhat , looks good, just minor update to to the docs/metrics.md. change this They are grouped by network types for any and sriov only. to include ib-sriov and example.

@aneeshkp thanks for the comments! Added ib-sriov in metric doc.

aneeshkp commented 4 years ago

/lgtm