search

k8snetworkplumbingwg / network-attachment-definition-client

A Golang Kubernetes client
Apache License 2.0
12 stars 37 forks source link

network-status: add GW info #42

Closed maiqueb closed 1 year ago

maiqueb commented 2 years ago

Hold this PR until default-route feature is fixed in spec (multi-net-spec) and multus-cni (comment by @s1061123, Nov 22, 2021)

-- The GW information is missing from the NetworkStatus annotation.

As such, it isn't possible to know which interface currently holds the default route.

maiqueb commented 2 years ago

/cc @s1061123 / @dougbtv / @phoracek

s1061123 commented 2 years ago

@maiqueb thank you for the PR, however can we hold this PR for now? Currently we have some gap about default-route annotation, between spec (multi-net-spec) and implementation and we don't clarify how to fix it.

So we need to fix default-route annotation in spec and multus then proceed the PR. Thank you so much for your help in advance.

maiqueb commented 2 years ago

@maiqueb thank you for the PR, however can we hold this PR for now? Currently we have some gap about default-route annotation, between spec (multi-net-spec) and implementation and we don't clarify how to fix it.

So we need to fix default-route annotation in spec and multus then proceed the PR. Thank you so much for your help in advance.

Of course. I just wanted to kick this off the ground, and this seemed the easiest way ( to me ...) .

dougbtv commented 2 years ago

Turns out that we actually had the examples in the spec! I went to go make a spec update last week, and... Alas, it's already there.

Then... I realize Miguel already has the code here :D Amazing! So, I think we should probably be ready to merge.

dougbtv commented 2 years ago

I think we might also want to merge against the release-v1.1 branch, too

maiqueb commented 2 years ago

@dougbtv can we revisit this ? AFAIU, the IPv6 thing was addressed in multus.

If not, I would appreciate if this PR were updated with the reasons it is being held. Because honestly, right now ... I don't know why.