search

k8snetworkplumbingwg / network-attachment-definition-client

A Golang Kubernetes client
Apache License 2.0
12 stars 37 forks source link

Update DeviceInfo spec to 1.1.0 #49

Closed ykulazhenkov closed 1 year ago

ykulazhenkov commented 1 year ago

Add "representor-device" field to support DeviceInfo format 1.1.0.

PR in DeviceInfoSpec repo https://github.com/k8snetworkplumbingwg/device-info-spec/pull/3

ykulazhenkov commented 1 year ago

cc @adrianchiris

ykulazhenkov commented 1 year ago

@amorenoz Could you please take a look at this PR?

ykulazhenkov commented 1 year ago

I think a unit test should be added to

https://github.com/k8snetworkplumbingwg/network-attachment-definition-client/blob/9679314e0bde11898b19f82494b1eff9ae9b075a/pkg/utils/net-attach-def_test.go#L142 .

I updated spec version in the test and added validation for the new field