search

k8snetworkplumbingwg / network-attachment-definition-client

A Golang Kubernetes client
Apache License 2.0
12 stars 37 forks source link

Support for HostIFName in DeviceInfo and vfid in PciDevice #67

Open jiayoukun opened 5 months ago

jiayoukun commented 5 months ago

1.The addition of these two fields is mainly to adapt to the deviceinfo of more types of network cards, such as veth in Calico and ovs-cni. Among them, ovs-cni has a greater need for this field. It relies on delivering flow tables under the vethName on the host to divert traffic. Adding this field can bind the vethName on the host with the corresponding Pod, eliminating the need to store the mapping between ovs and Pod in a separate database. I will adapt this content in a subsequent ovs-cni PR.

2.In metric monitoring, more information about the VF network card is needed, such as vfid and OrigVfName. I will later add OrigVfName to HostIFName and vfid to vfid in sriov-cni to facilitate reading the Pod's VfName and vfid.

jiayoukun commented 5 months ago

@s1061123 Can you check this pr and the multus-cni pr for me? multus-cni-pr

These two pr's allow CNI to implement a flexible deviceinfo.

s1061123 commented 5 months ago

This repository just implements https://github.com/k8snetworkplumbingwg/device-info-spec so we don't additional feature in it without any specification change. To modify this specification, please bring the topic in network plumbing working group meeting. See https://github.com/k8snetworkplumbingwg/community?tab=readme-ov-file#meetings for the details.

This meeeting is bi-weekly, so next meeting will be May 30th.