search

k8snetworkplumbingwg / ovs-cni

Open vSwitch CNI plugin
Apache License 2.0
224 stars 71 forks source link

send gratuitous arp upon assigning ip address #137

Closed pperiyasamy closed 4 years ago

pperiyasamy commented 4 years ago

Make ovs-cni to send gratuitous arp on the container interface so that other pods to update its ARP cache with new mac address for the existing ip address. This would enable ip reuse and supports seamless pod upgrade, scaling, redeployment scenarios.

Signed-off-by: Periyasamy Palanisamy periyasamy.palanisamy@est.tech

pperiyasamy commented 4 years ago

/release-note-none

pperiyasamy commented 4 years ago

/cc @JanScheurich

kubevirt-bot commented 4 years ago

@pperiyasamy: GitHub didn't allow me to request PR reviews from the following users: JanScheurich.

Note that only kubevirt members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/kubevirt/ovs-cni/pull/137#issuecomment-722506270): >/cc @JanScheurich Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
kubevirt-bot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: phoracek, pperiyasamy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/ovs-cni/blob/master/OWNERS)~~ [phoracek] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
JanScheurich commented 4 years ago

I'm happy with the final result.

/lgtm

kubevirt-bot commented 4 years ago

@JanScheurich: changing LGTM is restricted to collaborators

In response to [this](https://github.com/kubevirt/ovs-cni/pull/137#issuecomment-724683102): >I'm happy with the final result. > >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
phoracek commented 4 years ago

/hold cancel

pperiyasamy commented 4 years ago

/retest

pperiyasamy commented 4 years ago

The following test failed, say /retest to rerun all failed tests:

Looks timeout error occurred while pulling openvswitch rpm, triggered the retest. Let's see if it works now.

phoracek commented 4 years ago

@RamLavi could this be caused by any of the recent changes on the test infra?

https://storage.googleapis.com/kubevirt-prow/pr-logs/pull/kubevirt_ovs-cni/137/pull-e2e-ovs-cni/1326171243224764416/build-log.txt?Expires=1605023864&GoogleAccessId=prow-46%40kubevirt-240711.iam.gserviceaccount.com&Signature=fVUx8zb8ZhGmPUNxX5tx07xMZFGTM2G05LwG97zkWcwjZv6NqMyqUvLxaikr1N3xK%2FWfnHX8icEILoq%2BAEpBut3H1yYITNDVs2daHn64UxY63RrOlp0cCcAgEI7uIRhAc%2B525ZMDkTeqXC56BAkd0rVMaJvt3zm%2F5sCfqvDQBKEB8Hotc9D9kW0vqKYrzNrQ4uLNW8yu%2FZnsIPL2L7bH1Qb5qVoiLV8m6xZRHYGWcXvBjLh3vY3YKCg%2FAqOFiCrayiTd5GtycZagyYKqdGH1yT%2BH10yIu%2Bpp5hWa7h87ak3AyFFPtjjrwQuYJ2oPxY3WgCXNFU%2Fb1Yw5yLQVt57I9Q%3D%3D

phoracek commented 4 years ago

/retest