search

k8snetworkplumbingwg / ovs-cni

Open vSwitch CNI plugin
Apache License 2.0
224 stars 71 forks source link

make ovs socket file path as configurable property #142

Closed pperiyasamy closed 3 years ago

pperiyasamy commented 4 years ago

The ovs-cni currently hardcodes the ovs unix socket file path to /var/run/openvswitch/db.sock. But this would change across deployments. Hence introducing a global flat file configuration so that socket_file path can be specified and this is applied for all network attachment definition objects.

Signed-off-by: Periyasamy Palanisamy periyasamy.palanisamy@est.tech

pperiyasamy commented 4 years ago

/release-note-none

pperiyasamy commented 4 years ago

/cc @JanScheurich

kubevirt-bot commented 4 years ago

@pperiyasamy: GitHub didn't allow me to request PR reviews from the following users: JanScheurich.

Note that only kubevirt members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/kubevirt/ovs-cni/pull/142#issuecomment-734189614): >/cc @JanScheurich Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
phoracek commented 3 years ago

/lgtm /approve

kubevirt-bot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: phoracek, pperiyasamy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/ovs-cni/blob/master/OWNERS)~~ [phoracek] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment