search

k8snetworkplumbingwg / ovs-cni

Open vSwitch CNI plugin
Apache License 2.0
224 stars 71 forks source link

Rename all imports to refer to npwg #156

Closed phoracek closed 3 years ago

phoracek commented 3 years ago

The project was migrated from kubevirt GitHub org under k8snetworkplumbingwg, hence renaming all import references. Follow-up patches should address resource naming and image registry.

Fixes #152

phoracek commented 3 years ago

/retest

phoracek commented 3 years ago

/retest

phoracek commented 3 years ago

/approve cancel

fgimenez commented 3 years ago

/lgtm

(not sure if i can approve though :))

rhrazdil commented 3 years ago

The code change looks good to me. The description points to a PR 155, while I think want to point to this issue https://github.com/k8snetworkplumbingwg/ovs-cni/issues/152

/lgtm

kubevirt-bot commented 3 years ago

@rhrazdil: changing LGTM is restricted to collaborators

In response to [this](https://github.com/k8snetworkplumbingwg/ovs-cni/pull/156#issuecomment-842466632): >The code change looks good to me. >The description points to a PR 155, while I think want to point to this issue https://github.com/k8snetworkplumbingwg/ovs-cni/issues/152 > >/lgtm > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
phoracek commented 3 years ago

Thanks all, fixed the description.

/approve

kubevirt-bot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fgimenez, phoracek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/k8snetworkplumbingwg/ovs-cni/blob/master/OWNERS)~~ [phoracek] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
phoracek commented 3 years ago

/hold cancel /release-note-none