search

k8snetworkplumbingwg / ovs-cni

Open vSwitch CNI plugin
Apache License 2.0
224 stars 71 forks source link

docker, add virtual-tag docker-tag #166

Closed RamLavi closed 3 years ago

RamLavi commented 3 years ago

currently, only tagged commits are docker build+pushed to Quay. We also want to push regular main branch commits. This will allow us to run nightly tests in the future.

In order to do this, we add a docker-tag also non release commits.

RamLavi commented 3 years ago

/release-note-none

RamLavi commented 3 years ago

Can you explain please in the PR description why its needed? it is so they won't be deleted right ?

not exactly, I explained in the PR desc

phoracek commented 3 years ago

/lgtm /approve /hold

Feel free to cancel the hold once the review is done

kubevirt-bot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: phoracek, RamLavi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/k8snetworkplumbingwg/ovs-cni/blob/main/OWNERS)~~ [phoracek] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
oshoval commented 3 years ago

Can you explain please in the PR description why its needed? it is so they won't be deleted right ?

not exactly, I explained in the PR desc

same goal with different explanation ;]

feel free to unhold, thanks

RamLavi commented 3 years ago

/hold cancel