search

k8snetworkplumbingwg / ovs-cni

Open vSwitch CNI plugin
Apache License 2.0
224 stars 71 forks source link

multus, Update multus manifest #167

Closed RamLavi closed 3 years ago

RamLavi commented 3 years ago

the multus manifest has gone through some changes[0]. Updated the manifest in order to stay up to date.

[0] k8snetworkplumbingwg/multus-cni#627

RamLavi commented 3 years ago

/release-note-none

RamLavi commented 3 years ago

/retest looks like quay hiccup

RamLavi commented 3 years ago

looks like make docker-test is failing. locally I don't see an issue. let's wait and see if the issue is nontransient

RamLavi commented 3 years ago

/retest

RamLavi commented 3 years ago

/retest

RamLavi commented 3 years ago

Would you please expand the commit message? Why such a big change, where does it come from.

updated the commit message. The changes relevant to us are mainly the DaemonSet name kube-multus-ds and the image url ghcr.io/k8snetworkplumbingwg/multus-cni:stable. I initially thought that the old image docker.io/nfvpe/multus:stable is not available, which is what triggered this PR, but it was only a temporary thing..

So we can still bump to keep things up to date, but it's not as important as I initially thought. what do you think @phoracek ?

kubevirt-bot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: phoracek, RamLavi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/k8snetworkplumbingwg/ovs-cni/blob/main/OWNERS)~~ [phoracek] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment