search

k8snetworkplumbingwg / ovs-cni

Open vSwitch CNI plugin
Apache License 2.0
224 stars 71 forks source link

Bump libovsdb to 0.3.1 #169

Closed masap closed 3 years ago

masap commented 3 years ago

This PR modifies source of libovsdb from github.com/socketplane/libovsdb to github.com/ovn-org/libovsdb because the former was removed.

This PR also bump the libovsdb version to 0.3.1 because v0.1 and v0.2.0 causes error on make dep as follows. And 0.4.0and 0.5.0 requires go1.16.

libovsdb v0.1

$ make dep
/home/honma/git/ovs-cni/build/_output/bin//go//bin//go mod tidy
go: errors parsing go.mod:
/home/honma/git/ovs-cni/go.mod:13: no matching versions for query "v0.1"
make: *** [Makefile:89: dep] Error 1

libovsdb v0.2.0

$ make dep
/home/honma/git/ovs-cni/build/_output/bin//go//bin//go mod tidy
go: github.com/ovn-org/libovsdb@v0.2.0: parsing go.mod:
    module declares its path as: github.com/ebay/libovsdb
            but was required as: github.com/ovn-org/libovsdb
make: *** [Makefile:89: dep] Error 1

release-note

Bump libovsdb to 0.3.1

Signed-off-by: Masashi Honma masashi.honma@gmail.com

kubevirt-bot commented 3 years ago

Hi @masap. Thanks for your PR.

I'm waiting for a k8snetworkplumbingwg member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
masap commented 3 years ago

Hi ! I am a beginner of ovs-cni. I already passed all the test of make test. Is there any other test I should run ?

phoracek commented 3 years ago

/ok-to-test

Hello, welcome to the project! Let's see what CI says. Apart from integration tests you've already run, we also have end-to-end test suite running on a Kubernetes cluster. You can run it locally via make cluster-up cluster-sync functest

masap commented 3 years ago

@phoracek

You can run it locally via make cluster-up cluster-sync functest

Thanks ! I will try it.

masap commented 3 years ago

pull-e2e-ovs-cni failed with lint. Sorry, I forgot to run make lint. I will fix it tomorrow.

masap commented 3 years ago

Fixed.

masap commented 3 years ago

/test pull-e2e-ovs-cni

masap commented 3 years ago

Just now I recognize one mistake, I will fix it.

masap commented 3 years ago

Ok. Fixed.

kubevirt-bot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: masap, phoracek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/k8snetworkplumbingwg/ovs-cni/blob/main/OWNERS)~~ [phoracek] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment