search

k8snetworkplumbingwg / ovs-cni

Open vSwitch CNI plugin
Apache License 2.0
224 stars 71 forks source link

invoke ipam delete before net namespace check #178

Closed pperiyasamy closed 3 years ago

pperiyasamy commented 3 years ago

moving ipam.ExecDelbefore args.Netns == ""check, this makes sure ip is cleaned up in pod delete retry scenario, because some cases args.Netns is passed with empty string.

found this issue while testing whereabouts PR

Signed-off-by: Periyasamy Palanisamy periyasamy.palanisamy@est.tech

pperiyasamy commented 3 years ago

/release-note-none

kubevirt-bot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: phoracek, pperiyasamy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/k8snetworkplumbingwg/ovs-cni/blob/main/OWNERS)~~ [phoracek] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment