search

k8snetworkplumbingwg / ovs-cni

Open vSwitch CNI plugin
Apache License 2.0
224 stars 71 forks source link

Add support for CHECK command #212

Closed masap closed 3 years ago

masap commented 3 years ago

Also bump ovs-cni version to 0.4.0.

release-note

Add support for CHECK command
Bump ovs-cni version to 0.4.0

Signed-off-by: Masashi Honma masashi.honma@gmail.com

kubevirt-bot commented 3 years ago

Hi @masap. Thanks for your PR.

I'm waiting for a k8snetworkplumbingwg member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
masap commented 3 years ago

Yes, this is backwards compatible. I added some tests for 0.3.1.

phoracek commented 3 years ago

/cc @pperiyasamy

If you want to take a look. This PR makes it little clearer which CNI versions are supported

phoracek commented 3 years ago

@pperiyasamy does it look fine to you now?

pperiyasamy commented 3 years ago

@pperiyasamy does it look fine to you now?

@phoracek it looks good to me. Thanks @masap .

phoracek commented 3 years ago

/lgtm /approve

Thanks!

kubevirt-bot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: masap, phoracek, pperiyasamy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/k8snetworkplumbingwg/ovs-cni/blob/main/OWNERS)~~ [phoracek] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment