k8snetworkplumbingwg / ovs-cni

Open vSwitch CNI plugin
Apache License 2.0
222 stars 70 forks source link

Fix: missing annotations #216

Closed peterfromthehill closed 2 years ago

peterfromthehill commented 2 years ago

Just a small fix.

kubevirt-bot commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: peterfromthehill To complete the pull request process, please assign phoracek after the PR has been reviewed. You can assign the PR to them by writing /assign @phoracek in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/k8snetworkplumbingwg/ovs-cni/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kubevirt-bot commented 2 years ago

Hi @peterfromthehill. Thanks for your PR.

I'm waiting for a k8snetworkplumbingwg member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
phoracek commented 2 years ago

Nice catch, thanks for the PR @peterfromthehill o/

/test all

phoracek commented 2 years ago

@peterfromthehill would you please sign the commit? You can call git commit --amend -s and then force push the PR again. Let me know if you need any assistance

phoracek commented 2 years ago

/test all

kubevirt-bot commented 2 years ago

@peterfromthehill: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-e2e-ovs-cni d49707a4e37bfbe3e382a172ffb5512cddc53367 link true /test pull-e2e-ovs-cni
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
phoracek commented 2 years ago

/override pull-e2e-ovs-cni

Unrelated

phoracek commented 2 years ago

/release-note-none

phoracek commented 2 years ago

/override pull-e2e-ovs-cni