Closed peterfromthehill closed 2 years ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: peterfromthehill
To complete the pull request process, please assign phoracek after the PR has been reviewed.
You can assign the PR to them by writing /assign @phoracek
in a comment when ready.
The full list of commands accepted by this bot can be found here.
Hi @peterfromthehill. Thanks for your PR.
I'm waiting for a k8snetworkplumbingwg member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Nice catch, thanks for the PR @peterfromthehill o/
/test all
@peterfromthehill would you please sign the commit? You can call git commit --amend -s
and then force push the PR again. Let me know if you need any assistance
/test all
@peterfromthehill: The following test failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
pull-e2e-ovs-cni | d49707a4e37bfbe3e382a172ffb5512cddc53367 | link | true | /test pull-e2e-ovs-cni |
/override pull-e2e-ovs-cni
Unrelated
/release-note-none
/override pull-e2e-ovs-cni
Just a small fix.