search

k8snetworkplumbingwg / ovs-cni

Open vSwitch CNI plugin
Apache License 2.0
218 stars 70 forks source link

oci: Support podman #229

Closed oshoval closed 2 years ago

oshoval commented 2 years ago

Support (rootfull) podman OCI Auto detect running OCI

Bump kubevirtci to have podman support

Note: automation/check-patch.packages still has docker as default in case used with yam / dnf

None
oshoval commented 2 years ago

Addressed comments

qinqon commented 2 years ago

/lgtm /approve

oshoval commented 2 years ago

Thanks Quique @phoracek can you please take a look ?

oshoval commented 2 years ago

cosmetics ptal

qinqon commented 2 years ago

/lgtm

oshoval commented 2 years ago

Thanks Quique

kubevirt-bot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oshoval, phoracek, qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/k8snetworkplumbingwg/ovs-cni/blob/main/OWNERS)~~ [phoracek] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
oshoval commented 2 years ago

Thanks Petr

@phoracek , @qinqon

Can we create please a release, so CNAO will auto bump and take it ? Reason we need it is because when CNAO clones ovs-cni and run ovs-cni tests within CNAO it change dir to the cloned ovs-cni, and from there runs ./cluster/ssh.sh node01 -- sudo <cmd> this command still has the old ovs-cni with the old kubevirtci that doesn't have CRI auto detect so running podman on CI will fail

https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_project-infra/2125/rehearsal-pull-e2e-cluster-network-addons-operator-ovs-cni-functests/1529420827844415488

Thanks

./cluster/ssh.sh node01 -- sudo ovs-vsctl add-br br-test
stdout: ...
, stderr Cloning into '/tmp/deploy.ovs-cni.SGd3/github.com/k8snetworkplumbingwg/ovs-cni/_kubevirtci'...
Note: switching to '2202081102-e8daf721'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at e8daf72 Add kind-1.23-vgpu provider (#746)
selecting docker as container runtime
Trying to pull quay.io/kubevirtci/gocli:2202081102-e8daf721...
Getting image source signatures
Copying blob sha256:07faf7c8ff6b82f3d29ad58234e1c82c8b9b5f770167b8ba6a987d4ecf17c3be
Copying blob sha256:07faf7c8ff6b82f3d29ad58234e1c82c8b9b5f770167b8ba6a987d4ecf17c3be
Copying config sha256:2af2351a11519a3e0610cc8e509d91a309736d5864f2cb82bb0f7517c3ad3dca
Writing manifest to image destination
Storing signatures
Error: statfs /var/run/docker.sock: no such file or directory
phoracek commented 2 years ago

Good catch! https://github.com/k8snetworkplumbingwg/ovs-cni/releases/tag/v0.26.2