search

k8snetworkplumbingwg / ovs-cni

Open vSwitch CNI plugin
Apache License 2.0
218 stars 70 forks source link

Support for liveness probe for ovs-cni marker #231

Closed rthakur-est closed 2 years ago

rthakur-est commented 2 years ago

This change adds support for file based liveness probe for ovs-cni marker. This is done by changing the modification time of "/tmp/healthy" file from the marker code. And the exec probe verifies that the file has been modified in last one minute.

230

Signed-off-by: Ravindra Thakur ravindra.nath.thakur@est.tech

kubevirt-bot commented 2 years ago

Hi @rthakur-est. Thanks for your PR.

I'm waiting for a k8snetworkplumbingwg member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
phoracek commented 2 years ago

/retest

rthakur-est commented 2 years ago

/retest

kubevirt-bot commented 2 years ago

@rthakur-est: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/k8snetworkplumbingwg/ovs-cni/pull/231#issuecomment-1158712048): >/retest Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
phoracek commented 2 years ago

/retest

kubevirt-bot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: phoracek, rthakur-est

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/k8snetworkplumbingwg/ovs-cni/blob/main/OWNERS)~~ [phoracek] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
phoracek commented 2 years ago

/release-note-none

phoracek commented 2 years ago

/retest

Failed on timeout. I will post a patch increasing the 10 minute test timeout https://github.com/k8snetworkplumbingwg/ovs-cni/pull/232

phoracek commented 2 years ago

/retest

rthakur-est commented 2 years ago

@phoracek Thanks for the quick review.