search

k8snetworkplumbingwg / ovs-cni

Open vSwitch CNI plugin
Apache License 2.0
218 stars 70 forks source link

Fetch Multus manifest from its repo #240

Closed phoracek closed 2 years ago

phoracek commented 2 years ago

To prevent multus image and it manifest getting out of sync, fetch both from the latest sources.

What this PR does / why we need it:

While we always fetch the latest multus image, the manifest was kept under this repo. Due to that, the two could have get out of sync and fail to deploy. This patch fixes it.

Special notes for your reviewer:

Once Multus releases stable v4 image, it would be better to pin to that explicitly, to avoid regressions introduced in their main branch.

Release note:

NONE
kubevirt-bot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maiqueb, phoracek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/k8snetworkplumbingwg/ovs-cni/blob/main/OWNERS)~~ [phoracek] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
phoracek commented 2 years ago

/retest

kubevirt-bot commented 2 years ago

@phoracek: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-e2e-ovs-cni 4c181230d1a95ab8515a91106afaf169b94621ac link true /test pull-e2e-ovs-cni
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).