k8snetworkplumbingwg / ovs-cni

Open vSwitch CNI plugin
Apache License 2.0
220 stars 70 forks source link

cleanup useless check in mirror test helper funcion 'CreateEmptyMirrors' #242

Closed Ks89 closed 2 years ago

Ks89 commented 2 years ago

Quick cleanup of mirror testhelper function as requested here https://github.com/k8snetworkplumbingwg/ovs-cni/pull/227#discussion_r979462642

If createEmptyMirror executed without an error, it's safe to assume that mirror is really in ovsdb Mirror table.

kubevirt-bot commented 2 years ago

Hi @Ks89. Thanks for your PR.

I'm waiting for a k8snetworkplumbingwg member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
phoracek commented 2 years ago

/retest /lgtm /approve

kubevirt-bot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ks89, phoracek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/k8snetworkplumbingwg/ovs-cni/blob/main/OWNERS)~~ [phoracek] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
phoracek commented 2 years ago

@Ks89 one of the mirror tests seems flakey, would you please look into it?

{ Failure /tmp/src/github.com/k8snetworkplumbingwg/ovs-cni/tests/mirror_test.go:86
Expected
    <string>: 09:02:10.934759 IP 10.0.0.1 > 10.0.0.2: ICMP echo request, id 8, seq 1, length 64

to contain substring
    <string>: IP 10.0.0.2 > 10.0.0.1: ICMP echo reply
/tmp/src/github.com/k8snetworkplumbingwg/ovs-cni/tests/mirror_test.go:102}
Ks89 commented 2 years ago

We cannot reproduce this error in our environment, but it's probably related to a slower VM for kubevirtci. We tried to increase the timeout from 10s to 30s.

phoracek commented 2 years ago

/retest

phoracek commented 2 years ago

/lgtm

Thanks!

phoracek commented 2 years ago

/release-note-none