search

k8snetworkplumbingwg / ovs-cni

Open vSwitch CNI plugin
Apache License 2.0
220 stars 70 forks source link

Wait for tcpdump to start listening #243

Closed phoracek closed 2 years ago

phoracek commented 2 years ago

What this PR does / why we need it:

Installation and execution of tcpdump in the mirroring test is executed async. On a slower setup, the installation of tcpdump may take more time than the execution of ping inside the test - causing missed ping reply and failing the test.

With this patch, we wait for tcpdump to start recording traffic before the test continues its execution.

This pathc also removes waiting for the tcpdump file to get created, assuming it is not needed with the wait now happening in preparation phase.

Special notes for your reviewer:

Release note:

NONE
kubevirt-bot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: phoracek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/k8snetworkplumbingwg/ovs-cni/blob/main/OWNERS)~~ [phoracek] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
qinqon commented 2 years ago

/lgtm