Use two-stage container build

k8snetworkplumbingwg / ovs-cni

Open vSwitch CNI plugin

Apache License 2.0

220 stars 70 forks source link

Use two-stage container build #247

Closed phoracek closed 2 years ago

phoracek commented 2 years ago

What this PR does / why we need it:

In the current code, binaries are built locally to be only then put into the container image.

This patch aims to simplify part of that process, by containerizing builds. This should also help us avoid environment related issues, and later allow cross-platform building.

This PR also fixes incorrect .version rendering.

Release note:

NONE

qinqon commented 2 years ago

/lgtm /approve

kubevirt-bot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: phoracek, qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/k8snetworkplumbingwg/ovs-cni/blob/main/OWNERS)~~ [phoracek] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment