Closed wangyueyu64 closed 1 year ago
@wangyueyu64: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: wangyueyu64
Once this PR has been reviewed and has the lgtm label, please assign phoracek for approval by writing /assign @phoracek
in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Hi @wangyueyu64. Thanks for your PR.
I'm waiting for a k8snetworkplumbingwg member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:
Hello @wangyueyu64, thanks for the contribution! Looks interesting.
Sorry about the broken DCO link, here is a working one: https://github.com/kubevirt/kubevirt/blob/main/CONTRIBUTING.md#contributor-compliance-with-developer-certificate-of-origin-dco
If you would have any troubles pushing the PR, I'd be happy to assist.
In the current code, only the 'internal' type which is also the defaut type of interface is available when ovs-cni create one interface for port.
This commit added extra content to provides a possible way of setting interface's type when cni call func 'attachIfaceToBridge', In order to accommodate this function, also expanded type NetConf for ovs-cni and added extra arguments to function 'attachIfaceToBridge'.
This will allow the user to select a custom type of interface when creating a port on bridge.
What this PR does / why we need it:
Special notes for your reviewer:
Release note: