Plumbing to optionally build for arm64

k8snetworkplumbingwg / ovs-cni

Open vSwitch CNI plugin

Apache License 2.0

218 stars 70 forks source link

Plumbing to optionally build for arm64 #266

Closed courtland closed 1 year ago

courtland commented 1 year ago

What this PR does / why we need it:

Adds the ability to optionally build binaries for arm64 by setting GOARCH via Makefile variable overrides.

For example:

make GOARCH=arm64 build

make GOARCH=arm64 docker-build

Also fixes the non-dockerized install-go script to correctly download/install the versioned golang under an arm64 host.

Combined, this permits building the plugin(s) for arm64 and/or x86 on either type of host.

Special notes for your reviewer:

Related to #260

Release note:

Ability to build arm64 binaries

kubevirt-bot commented 1 year ago

Hi @courtland. Thanks for your PR.

I'm waiting for a k8snetworkplumbingwg member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.