k8snetworkplumbingwg / ovs-cni

Open vSwitch CNI plugin
Apache License 2.0
220 stars 70 forks source link

fix: bump to fedora:38 in dockerized tests, because 34 is missing, bump Multus, OVS, and kubevirtci #268

Closed courtland closed 1 year ago

courtland commented 1 year ago

What this PR does / why we need it:

quay.io pulled docker images for fedora:34

Special notes for your reviewer:

Fixes #267

Release note:

Fix dockerized tests after Fedora 34 EOL
kubevirt-bot commented 1 year ago

Hi @courtland. Thanks for your PR.

I'm waiting for a k8snetworkplumbingwg member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
phoracek commented 1 year ago

/retest

phoracek commented 1 year ago

CI failed installing dependencies on the e2e test cluster:

 + ./cluster/cli.sh ssh node01 -- sudo dnf install -y centos-release-nfv-openvswitch
selecting podman as container runtime
CentOS-8 - NFV OpenvSwitch                      8.2 kB/s | 3.0 kB     00:00    
CentOS-8 - NFV OpenvSwitch                      139 kB/s | 236 kB     00:01    
CentOS Stream 8 - AppStream                      12 kB/s | 4.4 kB     00:00    
CentOS Stream 8 - AppStream                      26 MB/s |  29 MB     00:01    
CentOS Stream 8 - BaseOS                        9.6 kB/s | 3.9 kB     00:00    
CentOS Stream 8 - BaseOS                         17 MB/s |  33 MB     00:01    
CentOS Stream 8 - Extras                         10 kB/s | 2.9 kB     00:00    
CentOS Stream 8 - Extras common packages         16 kB/s | 3.0 kB     00:00    
CentOS Stream 8 - Extras common packages         13 kB/s | 6.4 kB     00:00    
Stable Releases of Upstream github.com/containe  64 kB/s | 1.7 kB     00:00    
Stable Releases of Upstream github.com/containe 623 kB/s |  66 kB     00:00    
devel:kubic:libcontainers:stable:cri-o:1.22 (Ce 1.6 kB/s | 248  B     00:00    
Errors during downloading metadata for repository 'devel_kubic_libcontainers_stable_cri-o_1.22':
  - Status code: 404 for https://storage.googleapis.com/kubevirtci-crio-mirror/devel_kubic_libcontainers_stable_cri-o_1.22/repodata/repomd.xml (IP: 142.250.138.128)
Error: Failed to download metadata for repo 'devel_kubic_libcontainers_stable_cri-o_1.22': Cannot download repomd.xml: Cannot download repodata/repomd.xml: All mirrors were tried

Trying again, in case it was a temporary issue. If not, we will probably need to fix the CI environment.

phoracek commented 1 year ago

/retest

phoracek commented 1 year ago

Checking if bump of kubevirtci and OVS helps: https://github.com/k8snetworkplumbingwg/ovs-cni/pull/270

phoracek commented 1 year ago

/retest

phoracek commented 1 year ago

/retest

phoracek commented 1 year ago

/retest

Giving last chance to the flaky test.

courtland commented 1 year ago

/retest

Giving last chance to the flaky test.

Hah it worked!

phoracek commented 1 year ago

/lgtm /approve

Wonderful! Thanks for the fix @courtland

kubevirt-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: courtland, phoracek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/k8snetworkplumbingwg/ovs-cni/blob/main/OWNERS)~~ [phoracek] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
phoracek commented 1 year ago

/override pull-e2e-ovs-cni

phoracek commented 1 year ago

/retest

phoracek commented 1 year ago

/retest

phoracek commented 1 year ago

/retest

Sorry about the flaky CI.

kubevirt-bot commented 1 year ago

@courtland: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-e2e-ovs-cni e1fbdb2d66b4a7a08fb2527af88b490bbef2473f link true /test pull-e2e-ovs-cni
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
phoracek commented 1 year ago

Merging manually. The test failure is not related to the PR.

courtland commented 1 year ago

/retest

Sorry about the flaky CI.

It's all good. What would any CI be without some flakes? :D

Thanks for your help in getting this through.

phoracek commented 1 year ago

Thank you for pushing this forward! Much appreciated o/

phoracek commented 1 year ago

/cherry-pick release-0.29

kubevirt-bot commented 1 year ago

@phoracek: #268 failed to apply on top of branch "release-0.29":

Applying: fix: bump to fedora:38 in dockerized tests, because 34 is missing
Applying: Bump kubevirtci, Multus and OVS
Using index info to reconstruct a base tree...
M   cluster/cluster.sh
Falling back to patching base and 3-way merge...
Auto-merging cluster/cluster.sh
CONFLICT (content): Merge conflict in cluster/cluster.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 Bump kubevirtci, Multus and OVS
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/k8snetworkplumbingwg/ovs-cni/pull/268#issuecomment-1785276147): >/cherry-pick release-0.29 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
oshoval commented 1 year ago

@phoracek note please that if you take this you will need also those maybe https://github.com/k8snetworkplumbingwg/ovs-cni/pull/281 https://github.com/k8snetworkplumbingwg/ovs-cni/pull/282

they are due to this PR