search

k8snetworkplumbingwg / ovs-cni

Open vSwitch CNI plugin
Apache License 2.0
224 stars 71 forks source link

check hashicorp: Add hashicorp whitelist #279

Closed oshoval closed 1 year ago

oshoval commented 1 year ago

What this PR does / why we need it: Validates that no hashicorp are used beside the whitelisted ones (because they shifted to BSL license)

Special notes for your reviewer: Atm no hashicorp is used, but lets protect in case someone will add. Based on the whitelist that CNAO uses.

Release note:

None
kubevirt-bot commented 1 year ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

oshoval commented 1 year ago

@phoracek can you please enable git actions here ?

oshoval commented 1 year ago

some failures here are not ovs-mirror https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/k8snetworkplumbingwg_ovs-cni/279/pull-e2e-ovs-cni/1706952183326445568

oshoval commented 1 year ago

/retest

@phoracek ptal, regression was fixed we would need please to make sure git actions is enabled

phoracek commented 1 year ago

/lgtm /approve

kubevirt-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oshoval, phoracek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/k8snetworkplumbingwg/ovs-cni/blob/main/OWNERS)~~ [phoracek] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment