k8snetworkplumbingwg / ovs-cni

Open vSwitch CNI plugin
Apache License 2.0
218 stars 70 forks source link

kubevirtci: Downgrade to 1.25 #280

Closed oshoval closed 11 months ago

oshoval commented 11 months ago

What this PR does / why we need it: Align with CNAO. Check if here the tests are passing.

Special notes for your reviewer: Failures for example https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/k8snetworkplumbingwg_ovs-cni/279/pull-e2e-ovs-cni/1706970379018309632 pod can't be created failed to find plugin "calico" in path [/opt/cni/bin] It seems we need to update calico according https://github.com/projectcalico/calico/pull/6218 but not sure this is the problem

Release note:

None
kubevirt-bot commented 11 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: oshoval Once this PR has been reviewed and has the lgtm label, please assign phoracek for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/k8snetworkplumbingwg/ovs-cni/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kubevirt-bot commented 11 months ago

@oshoval: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-e2e-ovs-cni 8170957508f4d1498f5574da68f5ca5f5dde1880 link true /test pull-e2e-ovs-cni
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
oshoval commented 11 months ago

doesnt help

maybe worth to align more stuff which are different versus how cnao runs ovs cni, such as multus

oshoval commented 11 months ago

Note that if i tried to delete calico pods, sometimes one of them didnt manage to restart due to the same error as above and i saw this

$ oc logs -n kube-system kube-apiserver-node01  | grep validated
E0927 14:28:25.716451       1 authentication.go:63] "Unable to authenticate the request" err="[invalid bearer token, service account token has been invalidated]"

which is also mentioned here https://github.com/projectcalico/calico/issues/5684#issuecomment-1061582582

i think the right way is to try to align everything with CNAO, to see what is the moving part that does it (updating calico didnt help) worth to check if it is because we are using here multus thick (need to check if cnao uses thin, calico test only with thin)

see https://github.com/k8snetworkplumbingwg/ovs-cni/pull/281