Closed oshoval closed 11 months ago
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: oshoval, phoracek
The full list of commands accepted by this bot can be found here.
The pull request process is described here
We discussed this during the maintainer's call, and... it's more complex than you might think.
:snapshot
images in the main example deployment yaml, because this encourages users to deploy the latest version so that we get feedback more rapidly.Is there a reason why you can't track master for the OVS-CNI CI? Because I think that might actually be beneficial for both projects.
Hi For this repo we are using thin, not thick, we don't need thick atm for this repo. This repo doesn't run stuff a lot, so once we do, we prefer to have it stable, with whatever possible pinned and static, so we don't have surprises and can bump only when needed.
Using (as this PR does for thin plugin)
MULTUS_VERSION=v4.0.1
MULTUS_MANIFEST=https://raw.githubusercontent.com/k8snetworkplumbingwg/multus-cni/${MULTUS_VERSION}/deployments/multus-daemonset.yml
with $MULTUS_VERSION as the tag is legit right ? it takes yaml of v4.0.1, and the corresponding image
Note that we never used main on the yaml link, we always pinned the version, which is another reason why to not use latest image with static yaml
Since multus doesnt pin image correctly, pin it before deploying multus.
See https://github.com/k8snetworkplumbingwg/multus-cni/issues/1170
What this PR does / why we need it:
Special notes for your reviewer:
Release note: