Closed oshoval closed 9 months ago
/retest
OVS CNI has a user base outside CNAO. It is not justified to change its development tooling to be in sync with another project.
If you drop the target change and keep the gitignore modification, I will be happy to merge this.
Sure thx
is it fine btw to add another target and not replace ? (can be done also on follow PR if so) or double target doesnt make sense
Updated
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: oshoval, phoracek
The full list of commands accepted by this bot can be found here.
The pull request process is described here
I would rather not add a target to make it slightly more convenient for other projects. Sorry for the complication.
Np
btw if you want to consider an alias instead of a new target, anyhow not biggie
vendor: dep
/cherry-pick release-0.31
/cherry-pick release-0.29
/cherry-pick release-0.26
@oshoval: new pull request created: #299
@oshoval: new pull request created: #298
@oshoval: new pull request created: #300
What this PR does / why we need it: Add gopath to gitignore (created when using
make dep
)Special notes for your reviewer: once merged we might want to cherry-pick also to release-0.31 | release-0.29 | release-0.26
Release note: