search

k8snetworkplumbingwg / ovs-cni

Open vSwitch CNI plugin
Apache License 2.0
218 stars 70 forks source link

Add gopath to gitignore #293

Closed oshoval closed 9 months ago

oshoval commented 9 months ago

What this PR does / why we need it: Add gopath to gitignore (created when using make dep)

Special notes for your reviewer: once merged we might want to cherry-pick also to release-0.31 | release-0.29 | release-0.26

Release note:

None
oshoval commented 9 months ago

/retest

phoracek commented 9 months ago

OVS CNI has a user base outside CNAO. It is not justified to change its development tooling to be in sync with another project.

If you drop the target change and keep the gitignore modification, I will be happy to merge this.

oshoval commented 9 months ago

Sure thx

is it fine btw to add another target and not replace ? (can be done also on follow PR if so) or double target doesnt make sense

oshoval commented 9 months ago

Updated

kubevirt-bot commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oshoval, phoracek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/k8snetworkplumbingwg/ovs-cni/blob/main/OWNERS)~~ [phoracek] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
phoracek commented 9 months ago

I would rather not add a target to make it slightly more convenient for other projects. Sorry for the complication.

oshoval commented 9 months ago

Np btw if you want to consider an alias instead of a new target, anyhow not biggie vendor: dep

oshoval commented 9 months ago

/cherry-pick release-0.31

oshoval commented 9 months ago

/cherry-pick release-0.29

oshoval commented 9 months ago

/cherry-pick release-0.26

kubevirt-bot commented 9 months ago

@oshoval: new pull request created: #299

In response to [this](https://github.com/k8snetworkplumbingwg/ovs-cni/pull/293#issuecomment-1829359514): >/cherry-pick release-0.31 > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
kubevirt-bot commented 9 months ago

@oshoval: new pull request created: #298

In response to [this](https://github.com/k8snetworkplumbingwg/ovs-cni/pull/293#issuecomment-1829359626): >/cherry-pick release-0.29 > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
kubevirt-bot commented 9 months ago

@oshoval: new pull request created: #300

In response to [this](https://github.com/k8snetworkplumbingwg/ovs-cni/pull/293#issuecomment-1829359738): >/cherry-pick release-0.26 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.