Closed ykulazhenkov closed 3 months ago
Hi @ykulazhenkov. Thanks for your PR.
I'm waiting for a k8snetworkplumbingwg member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/retest
@ykulazhenkov hi. I believe that @SchSeba is planning to review this and help getting it merged once he's back at work.
Hi @ykulazhenkov can you please rebase I would like to see the github actions green on this one
Hi @ykulazhenkov can you please rebase I would like to see the github actions green on this one
@SchSeba done
@SchSeba Thanks for the review, Sebastian. I addressed your comments
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: e0ne, SchSeba, ykulazhenkov
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/retest
Add support for automatic bridge selection in HW offload mode
If deviceID argument is passed it can be used for automatic bridge selection: VF deviceID > PF > Bond(Optional) > Bridge
What this PR does / why we need it: This is required to optimize HW offloading use-case when Virtual Functions from multiple NICs on a host are exposed as a single resource.
Example:
We have two NICs on a host, and we want to expose all VFs from these NICs as a single resource. To support HW offloading, each NIC should be attached to a separate OVS bridge. Without changes from this PR, it is not possible to define NetworkAttachDefinition for OVS-cni, which will cover this use-case, because you need to explicitly specify the bridge name in the CNI config.
After changes from this PR, it is possible to define NetworkAttachDefinition without the bridge name and rely on the fact that ovs-cni will be able to automatically select the right OVS bridge (bridge to which NIC is attached) from the allocated Virtual Function (allocated by sriov device plugin, injected in
deviceID
field by multus)Special notes for your reviewer: Context is Software bridge management feature in sriov-network-operator
Release note:
cc @zeeke @adrianchiris @SchSeba