search

k8snetworkplumbingwg / ovs-cni

Open vSwitch CNI plugin
Apache License 2.0
224 stars 71 forks source link

Fix CMDCheck for hw offload use-case #302

Closed ykulazhenkov closed 7 months ago

ykulazhenkov commented 8 months ago

What this PR does / why we need it: In CMDCheck there is a check that validates if host/cont interfaces are veth interfaces. For HW offload this is not true. Ignore this check if ovsHWOffload is enabled Special notes for your reviewer: Release note:

NONE
kubevirt-bot commented 8 months ago

Hi @ykulazhenkov. Thanks for your PR.

I'm waiting for a k8snetworkplumbingwg member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
phoracek commented 8 months ago

@ykulazhenkov thank you for fixing this

/retest

phoracek commented 7 months ago

/approve

@ykulazhenkov thanks again for fixing this, @e0ne thanks for the review

kubevirt-bot commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: e0ne, phoracek, ykulazhenkov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/k8snetworkplumbingwg/ovs-cni/blob/main/OWNERS)~~ [phoracek] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment