Closed ykulazhenkov closed 4 months ago
Hi @ykulazhenkov. Thanks for your PR.
I'm waiting for a k8snetworkplumbingwg member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: SchSeba, ykulazhenkov
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/retest
What this PR does / why we need it: Currently, the function returns
"", false, err
if the interface is not found. The function's signature and usage assume that the function should not return an error if the interface is not found.https://github.com/k8snetworkplumbingwg/ovs-cni/blob/74349148acc8d20aac10b201b85bb099a17bdbdb/pkg/plugin/plugin.go#L315
Fix the function to return
"", false, nil
if the interface is not found. This change fixes CmdDel for the scenario when It is called after a failed CmdAdd or when the port is manually removed from the ovs. Special notes for your reviewer:Release note:
cc @SchSeba @e0ne