search

k8snetworkplumbingwg / ovs-cni

Open vSwitch CNI plugin
Apache License 2.0
218 stars 70 forks source link

fix: ovsdb.GetOvsPortForContIface should not return error if iface not found #305

Closed ykulazhenkov closed 4 months ago

ykulazhenkov commented 4 months ago

What this PR does / why we need it: Currently, the function returns "", false, err if the interface is not found. The function's signature and usage assume that the function should not return an error if the interface is not found.

https://github.com/k8snetworkplumbingwg/ovs-cni/blob/74349148acc8d20aac10b201b85bb099a17bdbdb/pkg/plugin/plugin.go#L315

Fix the function to return "", false, nil if the interface is not found. This change fixes CmdDel for the scenario when It is called after a failed CmdAdd or when the port is manually removed from the ovs. Special notes for your reviewer:

Release note:

"NONE"

cc @SchSeba @e0ne

kubevirt-bot commented 4 months ago

Hi @ykulazhenkov. Thanks for your PR.

I'm waiting for a k8snetworkplumbingwg member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
SchSeba commented 4 months ago

/ok-to-test

SchSeba commented 4 months ago

/lgtm /approve

kubevirt-bot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SchSeba, ykulazhenkov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/k8snetworkplumbingwg/ovs-cni/blob/main/OWNERS)~~ [SchSeba] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
SchSeba commented 4 months ago

/retest