k8snetworkplumbingwg / ovs-cni

Open vSwitch CNI plugin
Apache License 2.0
224 stars 71 forks source link

Add scalable functions (SF) support #310

Closed ghost closed 4 months ago

ghost commented 6 months ago

This patch adds support for scalable functions

(https://docs.nvidia.com/networking/display/bluefielddpuosv385/scalable+functions).

They are represented on the host as auxiliary devices.

In order to for the minimal codebase changes, this patch updated the sriovnet dependency, which already has support for SFs, together with its needed dependencies.

This patch also adds architecture detection to the Makefile.

What this PR does / why we need it: Add support for auxiliary devices.

Special notes for your reviewer: First time I contribute to ovs-cni. Apologies up front for any headaches 😄 .

Release note:

Support Scalable Functions
kubevirt-bot commented 6 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: naserdean Once this PR has been reviewed and has the lgtm label, please assign schseba for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/k8snetworkplumbingwg/ovs-cni/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kubevirt-bot commented 6 months ago

Hi @naserdean. Thanks for your PR.

I'm waiting for a k8snetworkplumbingwg member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
phoracek commented 6 months ago

Thanks for the contribution @naserdean! CC @SchSeba

kubevirt-bot commented 5 months ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.