search

k8snetworkplumbingwg / ovs-cni

Open vSwitch CNI plugin
Apache License 2.0
218 stars 70 forks source link

cluster: Allow kubevirtci tag overriding #319

Closed oshoval closed 1 month ago

oshoval commented 1 month ago

What this PR does / why we need it: It is helpful either manually or for example when used from CNAO, to use same tag of the cluster that CNAO deployed. Otherwise a kubevirtci tag mismatch can cause failures once running OVS e2e tests from CNAO.

Beside that fix go download, as the previous method doesn't work anymore. https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/k8snetworkplumbingwg_ovs-cni/319/pull-e2e-ovs-cni/1808463231954456576#1:build-log.txt%3A9859

go.mod was changed to fit the new download mechanism, but anyhow lately this is common on all repos to add the patch, i.e kubevirt as well that was changed lately https://github.com/kubevirt/kubevirt/blob/a3b2bf3a54936b3dedf1341f6927ba6bdda51557/go.mod#L210 This semantic is allowed, and even required when the toolchain arg will present.

Special notes for your reviewer:

Release note:

None
kubevirt-bot commented 1 month ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

phoracek commented 1 month ago

/lgtm /approve

kubevirt-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oshoval, phoracek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/k8snetworkplumbingwg/ovs-cni/blob/main/OWNERS)~~ [phoracek] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment