search

k8snetworkplumbingwg / ovs-cni

Open vSwitch CNI plugin
Apache License 2.0
224 stars 71 forks source link

pull e2e ovs-cni fix: install latest ginkgo #334

Closed tabuhariri closed 1 week ago

tabuhariri commented 1 week ago

getting this error in the ci job when trying to pull e2e ovs-cni: go: 'go install' requires a version when current directory is not in a module

What this PR does / why we need it:

Special notes for your reviewer:

Release note:

NONE
kubevirt-bot commented 1 week ago

Hi @tabuhariri. Thanks for your PR.

I'm waiting for a k8snetworkplumbingwg member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
phoracek commented 1 week ago

@tabuhariri thanks a lot for the fix! Let's see if this helps

phoracek commented 1 week ago

/retest

phoracek commented 1 week ago

/lgtm /approve

kubevirt-bot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: phoracek, tabuhariri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/k8snetworkplumbingwg/ovs-cni/blob/main/OWNERS)~~ [phoracek] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment