search

k8snetworkplumbingwg / sriov-cni

DPDK & SR-IOV CNI plugin
Apache License 2.0
307 stars 146 forks source link

set vlan to 0 if not defined. #180

Closed alonSadan closed 3 years ago

alonSadan commented 3 years ago

It is more common that when no vlan tag is specified, the interface will have no vlan at all.

The sriov-CNI acts differtly, and when a NAD is not configured with vlan, the VF will keep it's old vlan tag. This behaviour is not "natural" and could cause confusion.

This commit makes SRIOV-CNi treat no-valn as zero vlan, which will effectively remove the vlan tag from the VF.

To prevent future misunderstandings a note is added tot the README about the new behavior.

Signed-off-by: alonsadan asadan@redhat.com

alonSadan commented 3 years ago

/cc @zshi-redhat @adrianchiris @martinkennelly

adrianchiris commented 3 years ago

A couple of nits in the commit message:

This commit makes SRIOV-CNi treat no-valn as zero vlan,

CNi -> CNI valn -> vlan

To prevent future misunderstandings a note is added tot the README

tot -> to

alonSadan commented 3 years ago

A couple of nits in the commit message:

This commit makes SRIOV-CNi treat no-valn as zero vlan,

CNi -> CNI valn -> vlan

To prevent future misunderstandings a note is added tot the README

tot -> to

Thanks for the review. Done.