k8snetworkplumbingwg / sriov-cni

DPDK & SR-IOV CNI plugin
Apache License 2.0
298 stars 147 forks source link

Bump golangci-lint in Makefile as well #259

Closed jiriproX closed 1 year ago

jiriproX commented 1 year ago

make didn't work without it. Please keep golangci-lint version consistent in .github/workflows/static-scan.yml and in Makefile

jiriproX commented 1 year ago

@SchSeba please review it and approve it.

SchSeba commented 1 year ago

LGTM

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4958034830


Totals Coverage Status
Change from base Build 4784483752: 0.0%
Covered Lines: 422
Relevant Lines: 1106

💛 - Coveralls
adrianchiris commented 1 year ago

LGTM !

to avoid this split brain, it would be nice if the workflow just called make lint :)