k8snetworkplumbingwg / sriov-cni

DPDK & SR-IOV CNI plugin
Apache License 2.0
298 stars 147 forks source link

Add support for allmulticast flag #268

Closed mlguerrero12 closed 1 year ago

mlguerrero12 commented 1 year ago

This allows users to set the allmulticast mode for a VF.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 5323513802


Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/config/config.go 9 11 81.82%
pkg/utils/mocks/netlink_manager_mock.go 20 24 83.33%
pkg/utils/netlink_manager.go 0 6 0.0%
pkg/sriov/sriov.go 12 20 60.0%
<!-- Total: 41 61 67.21% -->
Files with Coverage Reduction New Missed Lines %
pkg/utils/mocks/netlink_manager_mock.go 1 80.12%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 5210643953: 1.4%
Covered Lines: 473
Relevant Lines: 1187

💛 - Coveralls
mlguerrero12 commented 1 year ago

@SchSeba, @adrianchiris, could you please take a look a this?

cgoncalves commented 1 year ago

Add new parameter to docs/configuration-reference.md

Also to README.md

mlguerrero12 commented 1 year ago

@cgoncalves, done

mlguerrero12 commented 1 year ago

Thank you @SchSeba, I addressed your comment.

SchSeba commented 1 year ago

Hi @mlguerrero12 can you please fix the test?

mlguerrero12 commented 1 year ago

Hi @Eoghan1232, could you please review this?

mlguerrero12 commented 1 year ago

@adrianchiris, I addressed your comments. Thank you.

adrianchiris commented 1 year ago

@adrianchiris, I addressed your comments. Thank you.

thanks for addressing !

adrianchiris commented 1 year ago

@mlguerrero12 @SchSeba i see that tuning CNI supports setting all multicast.

https://github.com/containernetworking/cni.dev/blob/main/content/plugins/current/meta/tuning.md

started to think if we really need it part of sriov-cni ? as all multicast is general for netdev no nessecarily for VF and tuning CNI already supports it.