search

k8snetworkplumbingwg / sriov-cni

DPDK & SR-IOV CNI plugin
Apache License 2.0
298 stars 147 forks source link

Delete ConfIFNames parameter #269

Closed mlguerrero12 closed 1 year ago

mlguerrero12 commented 1 year ago

This parameter is only used in a check that is not valid because only a single interface name is used by the plugin. Additionally, the func GetVFLinkNames was renamed to GetVFLinkName to reflect that a single name is returned.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 5177878515

Totals Coverage Status
Change from base Build 5122498764: 0.01%
Covered Lines: 420
Relevant Lines: 1102
💛 - Coveralls
mlguerrero12 commented 1 year ago

thanks @zeeke for your comment. You made me realize that we don't need this parameter at all. The interface name is taken from the var args. I will delete it.

And no, it won't break backwards compatibility for the above reason.